[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin: Add session Id (f6445ab)

Eliot Miranda notifications at github.com
Thu Dec 27 19:09:35 UTC 2018


Nicolas, Alistair,

    this is a useful conversation.  Consider adding it to CONTRIBUTING.md

_,,,^..^,,,_ (phone)

> On Dec 27, 2018, at 10:13 AM, akgrant43 <notifications at github.com> wrote:
> 
> Note that I like to see the "messy" decomposed history where each change
> has a rationale attached in a separate commit message.
> Of course, erratic trial and errors may benefit from a little rewrite of
> history, but not a squash, it's too violent for my taste, more something
> like a rebase -i.
> 
> I think maybe we're saying the same thing. Each commit in the main branch (Cog) should be single purpose and well documented, e.g. includes the rationale, which allows the reader to see the progression and consume the changes in small, understandable steps. I'm just suggesting one way to achieve that.
> 
> Leaving a messy (i.e. something that includes a mistake) decomposed history can just lead to confusion, e.g. I recently didn't squash down one of my PR's. Because it had every intermediate commit one reviewer thought I had committed a plugin built from dirty code, when in fact a later commit in the PR used clean code.
> 
>> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.


-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31791286
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20181227/631652d2/attachment-0001.html>


More information about the Vm-dev mailing list