[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Build instructions fail (#209)

[Javier Pimas]

Hi Eliot! sorry for the late answer. It seems it was overtaken by a
slightly bigger issue now, but thanks for the explanation anyway.

Cheers,
Pocho

On Sat, Feb 3, 2018 at 12:52 PM, OpenSmalltalk-Bot <notifications at github.com
> wrote:

> Hi Javier,
>
> > On Feb 2, 2018, at 11:50 AM, Javier Pimas <notifications at github.com>
> wrote:
> >
> > As this is a submodule, .git is not a directory but a file. Changing the
> line
> >
> > if [ -d `dirname $0`/../.git ]; then
> > to
> >
> > if [ -e `dirname $0`/../.git ]; then
> > makes the script work, but as I have no idea what this script does, I'm
> not sure if the change is correct
> >
>
> The platforms/Cross/vm/sqSCCSVersion.h file is supposed to contain the
> information that identifies a particular commit. It stands for Source Code
> Control System Version. With many SCCS systems, including Subversion, which
> was used to manage the source before git, one can use a metalanguage in the
> source file that is recognized and replaced by commit information on each
> commit. Git doesn't support this (?!?!?!). So we have to do it manually
> with this script. The script gets run automatically by the commit script
> scripts/gitci, but if you do a fresh check out you'll need to run the
> script to get the VM's --version command to print meaningful commit
> information.
>
> Ideally we would have rewritten the makefiles to do this automatically but
> not yet :-)
>
> Anyway, your fix looks correct. Please feel free to commit. Also you might
> copy my opening paragraph above ("The platforms ... meaningful commit
> information.") as a comment at the start of the script.
>
> Sorry for the mess. But most importantly, welcome!!! It's great to see you
> and Guido involved. I'm very excited. Thank you!
>
>
> Eliot _,,,^..^,,,_ (phone)
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-362825127>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AATPaVcijxg2VuLMQvIJyCQAPPxhJMioks5tRIDUgaJpZM4R3brI>
> .
>



-- 
Javier Pimás
Ciudad de Buenos Aires


-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-365622436
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20180214/b5d0cd5f/attachment.html>