[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 47cae4: Fix some unary option parsing in unix vm

GitHub noreply at github.com
Wed Jan 3 13:01:25 UTC 2018


  Branch: refs/heads/Fix_some_unary_option_parsing_in_unix_vm
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 47cae45e108b7c2b390162296be88a4ea50f0f31
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/47cae45e108b7c2b390162296be88a4ea50f0f31
  Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
  Date:   2018-01-03 (Wed, 03 Jan 2018)

  Changed paths:
    M platforms/unix/vm/sqUnixMain.c

  Log Message:
  -----------
  Fix some unary option parsing in unix vm

Argument parsing was ordered both
- by arity (-unary_option -binary_option binary_arg)
- by vm species (#ifdef STACKVM etc...)

The result is that some unary opt were found in the binary option else if branch

    else if (argc > 1)

Keep the VM species order (as it matches that of windows VM and legacy Mac OS VM)
Thus distribute the (argc > 1) protection on each and every binary option check.


  Commit: 91b7dd5971a558652d67f67079fa2e49aaea76aa
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/91b7dd5971a558652d67f67079fa2e49aaea76aa
  Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
  Date:   2018-01-03 (Wed, 03 Jan 2018)

  Changed paths:
    M platforms/Mac OS/vm/sqMacUnixCommandLineInterface.c

  Log Message:
  -----------
  Align legacy Mac OS option parsing with that of UNIX

Use VMOPTION macro so as to ease the diff with other OS.
Also change exit(0) in case of -help option like other OS.


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/47cae45e108b^...91b7dd5971a5


More information about the Vm-dev mailing list