[Vm-dev] Fwd: Merging FilesAttributesPlugin

[Eliot Miranda]

Hi Alistair,

On Tue, Jan 2, 2018 at 2:42 AM, Alistair Grant <akgrant0710 at gmail.com>
wrote:

>
> Hi Jakob,
>
> On 2 January 2018 at 06:46, Jakob Reschke <forums.jakob at resfarm.de> wrote:
> >
> >
> > Am 02.01.2018 04:43 schrieb "Eliot Miranda" <eliot.miranda at gmail.com>:
> >
> >  ... inst vars such as sCOFfn are set up in initialiseModule.  You're
> querying the SecurityPlugin on every access as in
> >
> >
> > canStatFilePath: aPathCString length: length
> > ...
> > (hasSecurityPlugin = 0) ifTrue: [^ true].
> > sCOFfn := interpreterProxy ioLoadFunction:
> 'secCanOpenFileOfSizeWritable' From: 'SecurityPlugin'.
> > sCOFfn ~= 0
> > ...
> >
> >
> > I have never looked at this before, so: can this variable name be
> spelled out, please, so it becomes legible for the uninitiated folk?
>
> I've made this change in my image, so it will flow through on the next
> update.
>

I don't think it's necessary.  The long vars are unwieldy and I'm sure
Jakob understands the convention now.

I just did a minor edit on the plain.  I wonder if it's time to move the
package to the VMMaker repository.  In any case I'll start including it in
builds.

_,,,^..^,,,_
best, Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20180103/073b725e/attachment.html>