[Vm-dev] VMProfileLinuxSupportPlugin causes Linux builds to fail

[Eliot Miranda]

Hi Tobias, Hi Alistair,

On Sat, Jun 16, 2018 at 11:02 AM, Eliot Miranda <eliot.miranda at gmail.com>
wrote:

> Hi Alistair, Hi Tobias,
>
> On Sat, Jun 16, 2018 at 7:05 AM, Alistair Grant <akgrant0710 at gmail.com>
> wrote:
>
>>
>> Hi Eliot and Everyone,
>>
>> Travis builds are failing due to compilation errors in
>> VMProfileLinuxSupportPlugin.  See e.g.
>> https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/393065793
>>
>> The most recent change to the file was in VMMaker.oscog-eem.2394 on 30
>> May 2018.
>>
>> Reverting VMProfileLinuxSupportPlugin.c to the previous version from
>> VMMaker.oscog-eem.2347 dated 8 March 2018 avoids the compilation
>> problems.
>>
>> Doing a diff of the two files gives:
>>
>> 2c2
>> < VMPluginCodeGenerator VMMaker.oscog-eem.2394 uuid:
>> 61ae96f8-fd2b-4208-87ff-cf1cd6b3f859
>> ---
>> > VMPluginCodeGenerator VMMaker.oscog-eem.2347 uuid:
>> 062614a7-e3da-4b30-997a-9568911b9ff5
>> 4c4
>> < VMProfileLinuxSupportPlugin VMMaker.oscog-eem.2394 uuid:
>> 61ae96f8-fd2b-4208-87ff-cf1cd6b3f859
>> ---
>> > VMProfileLinuxSupportPlugin VMMaker.oscog-eem.2347 uuid:
>> 062614a7-e3da-4b30-997a-9568911b9ff5
>> 6c6
>> < static char __buildInfo[] = "VMProfileLinuxSupportPlugin
>> VMMaker.oscog-eem.2394 uuid: 61ae96f8-fd2b-4208-87ff-cf1cd6b3f859 "
>> __DATE__ ;
>> ---
>> > static char __buildInfo[] = "VMProfileLinuxSupportPlugin
>> VMMaker.oscog-eem.2347 uuid: 062614a7-e3da-4b30-997a-9568911b9ff5 "
>> __DATE__ ;
>> 17,18c17,18
>> < #if defined(HAVE_DLFCN_H)
>> < # include <dlfcn.h>
>> ---
>> > #ifdef __OpenBSD__
>> > #include <dlfcn.h>
>> 19a20,23
>> > #ifndef _GNU_SOURCE
>> > # define _GNU_SOURCE
>> > #endif
>> > #include <link.h>
>> 104c108
>> < "VMProfileLinuxSupportPlugin VMMaker.oscog-eem.2394 (i)"
>> ---
>> > "VMProfileLinuxSupportPlugin VMMaker.oscog-eem.2347 (i)"
>> 106c110
>> < "VMProfileLinuxSupportPlugin VMMaker.oscog-eem.2394 (e)"
>> ---
>> > "VMProfileLinuxSupportPlugin VMMaker.oscog-eem.2347 (e)"
>>
>> Any suggestions?
>>
>
> Tobias, I believe that your changes on May 18th, VMMaker.oscog-topa.2385
> & VMMaker.oscog-topa.2386 are related.  Any suggestions?
>

Indeed, Tobias, it's your bug ;-)  :

topa 5/18/2018 17:15
VMProfileLinuxSupportPlugin  class>>#declareHeaderFilesIn: cg

cg
addHeaderFile: '<limits.h>';
addHeaderFile: '#if defined(HAVE_DLFCN_H)\# include <dlfcn.h>\#endif'
withCRs;
addHeaderFile: '#ifndef RTLD_NODELETE\# define RTLD_NODELETE 0\#endif'
withCRs

_,,,^..^,,,_
best, Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20180616/252d6bb6/attachment.html>