[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] added deployment scripts for sista VM (#225)

Fabio Niephaus notifications at github.com
Thu Mar 8 10:21:21 UTC 2018


fniephaus approved this pull request.



> @@ -31,6 +31,7 @@ jobs:
   - env: ARCH="linux32x86" FLAVOR="pharo.cog.spur" HEARTBEAT="threaded"
   - env: ARCH="linux32x86" FLAVOR="pharo.cog.spur" HEARTBEAT="itimer"
   - env: ARCH="linux32x86" FLAVOR="pharo.sista.spur" HEARTBEAT="threaded"
+  - env: ARCH="linux32x86" FLAVOR="pharo.sista.spur" HEARTBEAT="itimer"

why is the itimer version needed?

> @@ -12,7 +12,7 @@ readonly PR_SHA="${TRAVIS_PULL_REQUEST_SHA:-${APPVEYOR_PULL_REQUEST_HEAD_COMMIT}
 readonly BRANCH_NAME="${TRAVIS_BRANCH:-${APPVEYOR_REPO_BRANCH}}"
 readonly TAG_NAME="${TRAVIS_TAG:-${APPVEYOR_REPO_TAG_NAME}}"
 
-if [[ "${FLAVOR}" != "pharo.cog.spur" ]]; then
+if ! ([[ "${FLAVOR}" = "pharo.cog.spur" ]] || [[ "${FLAVOR}" = "pharo.sista.spur" ]]); then

Line 5 needs to be updated as well ;)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/225#pullrequestreview-102249570
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20180308/b5594014/attachment.html>


More information about the Vm-dev mailing list