[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)
akgrant43
notifications at github.com
Fri May 11 17:36:18 UTC 2018
akgrant43 commented on this pull request.
One minor fix for RiscOS and this is good to go (I'll update the code for Unix after this has been integrated).
> @@ -407,6 +407,11 @@ sqInt sqFileStdioHandlesInto(SQFile files[3]) {
return 0;
}
+sqInt sqFileDescriptorType(int fdNum) {
+ //Not implemented
+ return 0;
RiscOS should return -1 (error), not 0 (no console).
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/254#pullrequestreview-119517188
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20180511/c577fb76/attachment.html>
More information about the Vm-dev
mailing list