[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Pullrequest/vmmaker (#305)

Nicolas Cellier notifications at github.com
Wed Nov 14 10:07:16 UTC 2018


Example of String/Symbol mess: find the real changes in:

https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/4accb9e06df33a2326c0b2934cf15ac89edf3c06

Example of parallel branches mess:

This commit is a merge of VMMaker.oscog-nice.2109 and VMMaker.oscog-eem.2109, and thus should have 2 parents instead of one:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/d5fae5a534a0c8b3eaa6b4756529aee3935e9dcd

Its parent is VMMaker.oscog-nice.2109
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/af7947fbea937adcc14aa979d39259e49e898ce1

and its parent has been marked incorrectly as VMMaker.oscog-eem.2109
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a97aba90b29305784f37a1561726dbe94218fb2f

We thus see diffs between two different branches VMMaker.oscog-nice.2109 and VMMaker.oscog-eem.2109 which is completely irrelevant...

Also, it would be good to append the name of original Monticello package (and why not URL) at the end of the commit message for easing diagnostics!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/305#issuecomment-438607783
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20181114/c835cb9a/attachment-0001.html>


More information about the Vm-dev mailing list