[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Pullrequest2/vmmaker (#308)

Ben Coman notifications at github.com
Thu Nov 22 00:10:10 UTC 2018


Thx George for correcting the commit dates.  The network graph looks much better.
Its good to have the mcz name there too, but its a bit opaque having "only" the mcz name.  
So I have a suggestion to fine-tune that, basically merging the first three lines of the mcz-commit-message onto one line for the git-commit-message.  Shown here...
![vmmaker-extra-comment](https://user-images.githubusercontent.com/1713447/48874095-624d3980-ee2c-11e8-8d22-3cbb62bdfe02.png)

You should be able to reproduce that by doing...
```
$ git remote add ben  https://github.com/bencoman/opensmalltalk-vm.git
$ git fetch ben
$ git checkout -b ben/vmmaker-unmerged   # taken from this pull request
$ git branch vmmaker-comment-mod
$ git checkout vmmaker-comment-mod
$ git filter-branch -f --msg-filter /your/path/to/vmmaker-comment-mod.awk
````
where **vmmaker-comment-mod.awk** is...
```
#!/usr/bin/awk -f
(NR==1) {printf "%s.mcz ", $0 ; next}
(NR==2) {printf "%s ", $0; next}
{print}
```
Adding the ".mcz" will make vmmaker more explicit after merging into the Cog mainline.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/308#issuecomment-440858113
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20181121/26c6c0b6/attachment.html>


More information about the Vm-dev mailing list