[Vm-dev] Pull request: changes for Mac build system

Tim Johnson digit at sonic.net
Tue Oct 23 15:58:25 UTC 2018


Hi,

I've made a branch with the following commit message:

    Use output of xcode-select to determine path of Xcode in Mac Makefile, instead of hard-coding.
    xcode-select allows for multiple versions of Xcode to be installed and to be selected by the user.
    DO NOT put a space in a renamed Xcode.app, however: this will break SDK detection in the Makefile.
    
    Add OS X 10.14 SDKs for x64 build, as supplied by Xcode 10.



which does the following:

build.macos32x86/common/Makefile.flags & build.macos64x64/common/Makefile.flags:


-XCODE:=/Applications/Xcode.app/Contents/Developer
+XCODE:=$(shell /usr/bin/xcode-select -p)


and:

build.macos64x64/common/Makefile.flags

-SDKs:=MacOSX10.10.sdk MacOSX10.11.sdk MacOSX10.12.sdk MacOSX10.13.sdk
+SDKs:=MacOSX10.10.sdk MacOSX10.11.sdk MacOSX10.12.sdk MacOSX10.13.sdk MacOSX10.14.sdk


However, I'm not sure I have permissions to push my branch and create a pull request.  If that's the model you use, please let me know.  I am use @tcj on github.

Thanks,
Tim



More information about the Vm-dev mailing list