[Vm-dev] Squeak.rc FILEVERSIONVALUES

[Alistair Grant]

Hi Ben,

I've never built squeak.cog.spur on windows (or any other platform
:-)), but if you look at the appveyor log you can see that
FILEVERSIONVALUES being defined:

https://ci.appveyor.com/project/OpenSmalltalk/vm/build/job/a6x5mg5uw7p8c882?fullLog=true

hth,
Alistair

On Wed, 19 Sep 2018 at 15:17, Ben Coman <btc at openinworld.com> wrote:
>
>
> I tried to build via "build.win32x86/squeak.cog.spur/mvm" but got an error with the resource file...
> ```
> i686-w64-mingw32-windres \
>     --include-dir ../../platforms/win32/misc \
>     -D_WIN32 \
>     -DFILEVERSIONVALUES=,,, '-DFILEVERSIONSTRING=\"...\\0\"'  \
>     -i Squeak.rc \
>     -o builddbg/vm/Squeak.res
> ==>
> i686-w64-mingw32-windres: Squeak.rc:7: syntax error
> make[1]: *** [../common/Makefile:296: Squeak.res] Error 1
> ```
>
> I see a reference at the top of [1] to this for Pharo but no direct resolution is mentioned.
> [1] http://forum.world.st/Compiling-the-windows-32-bits-vm-td5072691.html
>
> [Squeak.rc:7](https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/build.win32x86/squeak.cog.spur/Squeak.rc#L7) is...
> ```
> FILEVERSION FILEVERSIONVALUES
> ```
> and the value ",,," supplied for FILEVERSIONVALUES on the command line seems invalid.
>
>
> I see Pharo has hardcoded the value...
> https://www.diffchecker.com/O36vXV5b
> https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/build.win32x86/pharo.cog.spur/Pharo.rc#L7
> ```
>  FILEVERSION 5,0,0,0
> ```
>
> and if I do the same in Squeak.rc the build completes.
> So should I submit a PR for that, or does anyone know how the command line "FILEVERSIONVALUES"
> is supposed to be supplied a proper value?  Searching the repo doesn't give any hints...
> https://github.com/OpenSmalltalk/opensmalltalk-vm/search?q=FILEVERSIONVALUES
>
>
> cheers -ben