[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Mixed SmallInteger/Float comparison is inexact in Spur64 when jitted (#417)

Eliot Miranda notifications at github.com
Mon Aug 26 22:45:36 UTC 2019


also, in e.g. CogObjectRepresentationFor64BitSpur>>genFloatComparison:orIntegerComparison:invert:boxed: or anywhere else the issue comes up it would be good for non-experts to extend the comment, so that instead of just

	"If floatRcvr == (double) intArg then use compareInt(intArg,(int64) floatRcvr)"

it says
	"If floatRcvr == (double) intArg then use compareInt(intArg,(int64) floatRcvr).
	 see https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/417"
or
	"If floatRcvr == (double) intArg then use compareInt(intArg,(int64) floatRcvr).
	 because in 64-bits SmallInteger has more significant bits (60) than Float (53)"

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/417#issuecomment-525062104
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20190826/77435d99/attachment.html>


More information about the Vm-dev mailing list