[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] MUSL deltas (mostly harmless) (#450)

Nicolas Cellier notifications at github.com
Tue Dec 24 09:56:55 UTC 2019


nicolas-cellier-aka-nice commented on this pull request.



> @@ -213,7 +213,8 @@ ioInitSecurity(void)
   if (imagePathLen)
     strncpy(secureUserDirectory, imageName, imagePathLen);
   else {
-    getwd(secureUserDirectory);
+/*@@MUSL@@*/
+    getcwd(secureUserDirectory, imagePathLen);

Does it work? We're passing `imagePathLen==0` here.
Shouldn't it be the buffer size, `MAXPATHLEN`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/450#pullrequestreview-336152034
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20191224/aec2887f/attachment.html>


More information about the Vm-dev mailing list