[Vm-dev] Failed: OpenSmalltalk/opensmalltalk-vm#1892 (win_generate_mouse_wheel_events - b982355)

[Fabio Niephaus]

On Thu, Dec 26, 2019 at 10:04 PM Nicolas Cellier <
nicolas.cellier.aka.nice at gmail.com> wrote:

>
> Argh,
> When I change a win32 file, Travis build fail (?)
> When I change a linux file, it's Appveyor that fails (!)
>
> Those failures are very instructive...
> They tell us that our infrastructure sucks ;)
>

Yes, that's annoying. Nonetheless, a "you broke something" is still better
than nothing, and we had nothing for a very long time. ;) Let us know if
you have any suggestions for improving our infrastructure!

Maybe we should start with disabling unused builds, such as the
Squeak+minheadless builds or maybe even some of the Pharo builds...I'm not
aware of anyone using all these binaries.

Fabio


>
> Le jeu. 26 déc. 2019 à 22:01, Travis CI <builds at travis-ci.org> a écrit :
>
>>
>>
>> OpenSmalltalk
>>
>> /
>>
>> opensmalltalk-vm
>>
>> <https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm?utm_medium=notification&utm_source=email>
>>
>> [image: branch icon]win_generate_mouse_wheel_events
>> <https://github.com/OpenSmalltalk/opensmalltalk-vm/tree/win_generate_mouse_wheel_events>
>> [image: build has failed]
>> Build #1892 failed
>> <https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/629774919?utm_medium=notification&utm_source=email>
>> [image: arrow to build time]
>> [image: clock icon]17 mins and 10 secs
>>
>> [image: Nicolas Cellier avatar]Nicolas Cellier
>> b982355 CHANGESET →
>> <https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/95e821968134...b982355886cf>
>>
>> Deliver mouse wheel events only once they reach a threshold
>>
>> On some devices (example Mac trackpad), many events are generated with
>> small deltas.
>> This is overwhelming the EventSensor loop at image side to the detriment
>> of user experience.
>> Workaround by letting the VM accumulate those deltas until they reach a
>> threshold before delivering.
>>
>> In case of high delta values, we generate a single value.
>> It's up to image side to handle those values
>> (until now, Squeak 5.3 just ignored them, VM is not to be blamed for
>> that).
>>
>> Note: 2 values are hardcoded for now
>> - the timeout for stopping accumulation (500ms)
>> - the threshold for delivering the event to the image.
>>
>> The threshold could have been WHEEL_DELTA, but it gives bad sensitivity
>> on my own device, so use only a fraction of that in the hope that it fits
>> other devices too.
>> Please report if those tuning are inappropriate. We may add parameters in
>> the future if necessary...
>>
>> Want to know about upcoming build environment updates?
>>
>> Would you like to stay up-to-date with the upcoming Travis CI build
>> environment updates? We set up a mailing list for you!
>> SIGN UP HERE <http://eepurl.com/9OCsP>
>>
>> [image: book icon]
>>
>> Documentation <https://docs.travis-ci.com/> about Travis CI
>> Have any questions? We're here to help. <support at travis-ci.com>
>> Unsubscribe
>> <https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&utm_medium=notification&utm_source=email>
>> from build emails from the OpenSmalltalk/opensmalltalk-vm repository.
>> To unsubscribe from *all* build emails, please update your settings
>> <https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email>.
>>
>> [image: black and white travis ci logo] <https://travis-ci.com>
>>
>> Travis CI GmbH, Rigaer Str. 8, 10427 Berlin, Germany | GF/CEO: Randy
>> Jacops | Contact: contact at travis-ci.com | Amtsgericht Charlottenburg,
>> Berlin, HRB 140133 B | Umsatzsteuer-ID gemäß §27 a Umsatzsteuergesetz:
>> DE282002648
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20191226/8f577852/attachment-0001.html>