[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 9e2b99: Handle mouse wheel events like other mouse events

Nicolas Cellier noreply at github.com
Sat Dec 28 13:18:12 UTC 2019


  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 9e2b99c2172f686f2c0a7265d8301206c6cf2788
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9e2b99c2172f686f2c0a7265d8301206c6cf2788
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2019-12-27 (Fri, 27 Dec 2019)

  Changed paths:
    M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m
    M platforms/unix/vm/sqUnixEvent.c

  Log Message:
  -----------
  Handle mouse wheel events like other mouse events

Mouse wheel events now have both buttons and modifiers states set correctly, like any other mouse event.


  Commit: cce69c559d93e6fcc158ef64eb6e8030fbd4ce8f
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/cce69c559d93e6fcc158ef64eb6e8030fbd4ce8f
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2019-12-27 (Fri, 27 Dec 2019)

  Changed paths:
    M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m

  Log Message:
  -----------
  Use precise scrolling deltas if available on OSX


  Commit: 92fa6f8a6d3688633ae142c1482918d9eeaec9bd
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/92fa6f8a6d3688633ae142c1482918d9eeaec9bd
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2019-12-27 (Fri, 27 Dec 2019)

  Changed paths:
    M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m

  Log Message:
  -----------
  OSX: accumulate enough delta before sending the wheel event to the image


  Commit: 9d26c9785d6fce76c69095f51c57309c65afa6e1
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9d26c9785d6fce76c69095f51c57309c65afa6e1
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2019-12-27 (Fri, 27 Dec 2019)

  Changed paths:
    M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m

  Log Message:
  -----------
  Convert OSX point units into scrolling units

Set the limit to 20 scrolling units to restrain the flow of events delivered to image
That's about 7 points (1/10 inch), not exactly the smoothest.
But if we want smoother scroll, we have to accelerate event handling at image side first.

The threshold might become a parameter, but for now YAGNI.

Note: the scrolling unit of 120 units per mouse wheel notch comes from moz.dev.
The fact that we convert a single notch to 3 lines is a Squeak convention
See https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/41


  Commit: 83e43ee7138f8a1b76ed774c3972f2691776778a
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/83e43ee7138f8a1b76ed774c3972f2691776778a
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2019-12-28 (Sat, 28 Dec 2019)

  Changed paths:
    M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m
    M platforms/unix/vm/sqUnixEvent.c

  Log Message:
  -----------
  Merge pull request #462 from OpenSmalltalk/fix_osx_linux_mouse_wheel

Fix osx linux mouse wheel


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/48af339d0527...83e43ee7138f


More information about the Vm-dev mailing list