[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 39a073: Issue 368: FileAttributesPlugin close dir when emp...

Eliot Miranda noreply at github.com
Wed Feb 6 23:51:19 UTC 2019


  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 39a073c11df309658f38b1aa86752179dcc6083a
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/39a073c11df309658f38b1aa86752179dcc6083a
  Author: AlistairGrant <akgrant0710 at gmail.com>
  Date:   2019-02-05 (Tue, 05 Feb 2019)

  Changed paths:
    M platforms/unix/plugins/FileAttributesPlugin/faSupport.c

  Log Message:
  -----------
  Issue 368: FileAttributesPlugin close dir when empty on iteration

faOpenDirectory() should leave the directory closed if it is empty.
On linux the directory was left open, creating a resource leak.


  Commit: e9fee6facb61c1163e820673bd8734b59a831535
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/e9fee6facb61c1163e820673bd8734b59a831535
  Author: AlistairGrant <akgrant0710 at gmail.com>
  Date:   2019-02-06 (Wed, 06 Feb 2019)

  Changed paths:
    M platforms/unix/plugins/FilePlugin/sqUnixFile.c

  Log Message:
  -----------
  FilePlugin: reopen the directory when jumping around

In dir_Lookup, when jumping around, i.e. index ~= lastIndex+1, reopen
the directory rather than rewinding.

This is required as the open directory caches entries (at least with
CIFS mounted file system), and if files are deleted between calls the
wrong answer will be returned.

Issue: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/368


  Commit: a838346b1a67712cc28298534dafbd0c26ea34fb
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a838346b1a67712cc28298534dafbd0c26ea34fb
  Author: Eliot Miranda <eliot.miranda at gmail.com>
  Date:   2019-02-06 (Wed, 06 Feb 2019)

  Changed paths:
    M platforms/unix/plugins/FileAttributesPlugin/faSupport.c
    M platforms/unix/plugins/FilePlugin/sqUnixFile.c

  Log Message:
  -----------
  Merge pull request #371 from akgrant43/Issue368

Deleting a directory on a CIFS mounted file system fails


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/694dfe3ed015...a838346b1a67


More information about the Vm-dev mailing list