[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 24df81: Let warnPrintf take a char * argument in platforms...

GitHub noreply at github.com
Sat Jan 5 13:24:07 UTC 2019


  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 24df818454b177735fdf894bda5d028fc95e1c44
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/24df818454b177735fdf894bda5d028fc95e1c44
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2019-01-05 (Sat, 05 Jan 2019)

  Changed paths:
    M platforms/win32/plugins/AsynchFilePlugin/sqWin32AsyncFilePrims.c
    M platforms/win32/plugins/HostWindowPlugin/sqWin32HostWindowPlugin.c
    M platforms/win32/plugins/JoystickTabletPlugin/sqWin32Joystick.c
    M platforms/win32/plugins/MIDIPlugin/sqWin32MIDI.c
    M platforms/win32/plugins/SoundPlugin/sqWin32Sound.c
    M platforms/win32/vm/sqWin32.h
    M platforms/win32/vm/sqWin32Alloc.c
    M platforms/win32/vm/sqWin32Main.c
    M platforms/win32/vm/sqWin32PluginSupport.c
    M platforms/win32/vm/sqWin32Service.c
    M platforms/win32/vm/sqWin32Utils.c
    M platforms/win32/vm/sqWin32Window.c

  Log Message:
  -----------
  Let warnPrintf take a char * argument in platforms/win32 VM support files

This is required to make its signature uniform across different platforms and compatible with minheadless variant
Provide a warnPrintfW for the rare cases when we need to print a WCHAR* on the console
Provide a warnPrintfT macro taking a TCHAR* for the -DUNICODE agnostic clients

Let DPRINTF macro which depend on warnPrintf do its conversion to char*
Note that DBGPRINTF macro will remain dedicated to TCHAR* (defined as warnPrintfT)

Accordingly also change back the DPRINTF function (not he macro...) to take a char *
This implies using a few ASCII API variants rather than generic API variants
(SendMessageA,  OutputDebugStringA)

[skip travis]


  Commit: 850342ef63529da114f6b145848fd9db581ba877
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/850342ef63529da114f6b145848fd9db581ba877
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2019-01-05 (Sat, 05 Jan 2019)

  Changed paths:
    M platforms/minheadless/windows/sqPlatformSpecific-Win32.h

  Log Message:
  -----------
  Provide the minheadless support for warnPrintfW/T


  Commit: 96e46208c0cff847e428aacd2c27f7750e51248a
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/96e46208c0cff847e428aacd2c27f7750e51248a
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2019-01-05 (Sat, 05 Jan 2019)

  Changed paths:
    M build.win32x86/common/Makefile.plugin
    M build.win32x86/common/Makefile.tools
    M build.win64x64/common/Makefile.plugin
    M build.win64x64/common/Makefile.tools

  Log Message:
  -----------
  NO_STD_FILE_SUPPORT is now implied by WIN32_FILE_SUPPORT

So no need to provide this -D compiler option anymore, it generates useless warnings
Also remove -mdll in WIN64, it's an unsupported option that also generates a warning


  Commit: a81683b191ce7c8154d9b5279e75d45b588af0a8
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a81683b191ce7c8154d9b5279e75d45b588af0a8
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2019-01-05 (Sat, 05 Jan 2019)

  Changed paths:
    M platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c

  Log Message:
  -----------
  Remove a compiler warning - losing const qualifier


  Commit: 6f2cb8ad232f9f5c1e9aa25f89b5f101ea9684d5
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/6f2cb8ad232f9f5c1e9aa25f89b5f101ea9684d5
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2019-01-05 (Sat, 05 Jan 2019)

  Changed paths:
    M platforms/minheadless/windows/sqWin32.h
    M platforms/minheadless/windows/sqWin32Common.c

  Log Message:
  -----------
  DIscard now unused fromSqueak fromSqueak2 fromSqueakInto from minheadless too

Related to issue #345
[skip travis]


  Commit: 005e3dc34a26e6d8edeb4461e5dd121a9a05dca0
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/005e3dc34a26e6d8edeb4461e5dd121a9a05dca0
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2019-01-05 (Sat, 05 Jan 2019)

  Changed paths:
    M build.win32x86/common/Makefile.plugin
    M build.win32x86/common/Makefile.tools
    M build.win64x64/common/Makefile.plugin
    M build.win64x64/common/Makefile.tools
    M platforms/minheadless/windows/sqPlatformSpecific-Win32.h
    M platforms/minheadless/windows/sqWin32.h
    M platforms/minheadless/windows/sqWin32Common.c
    M platforms/win32/plugins/AsynchFilePlugin/sqWin32AsyncFilePrims.c
    M platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c
    M platforms/win32/plugins/HostWindowPlugin/sqWin32HostWindowPlugin.c
    M platforms/win32/plugins/JoystickTabletPlugin/sqWin32Joystick.c
    M platforms/win32/plugins/MIDIPlugin/sqWin32MIDI.c
    M platforms/win32/plugins/SoundPlugin/sqWin32Sound.c
    M platforms/win32/vm/sqWin32.h
    M platforms/win32/vm/sqWin32Alloc.c
    M platforms/win32/vm/sqWin32Main.c
    M platforms/win32/vm/sqWin32PluginSupport.c
    M platforms/win32/vm/sqWin32Service.c
    M platforms/win32/vm/sqWin32Utils.c
    M platforms/win32/vm/sqWin32Window.c

  Log Message:
  -----------
  Merge pull request #347 from OpenSmalltalk/ascii_warnPrintf

Ascii warn printf


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/1d97d7952e57...005e3dc34a26
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the Vm-dev mailing list