[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 0ebda8: ALLOCA_LIES_SO_USE_GETSP macro is obsolete [ci ski...

[GitHub]

  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 0ebda8e62bb0f74ad2e65fdde9f931eb20d216f4
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0ebda8e62bb0f74ad2e65fdde9f931eb20d216f4
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2019-01-05 (Sat, 05 Jan 2019)

  Changed paths:
    M CMakeLists.txt
    M build.win32x86/pharo.cog.spur.lowcode/Makefile
    M build.win32x86/pharo.cog.spur/Makefile
    M build.win32x86/pharo.sista.spur/Makefile
    M build.win32x86/squeak.cog.spur.lowcode/Makefile

  Log Message:
  -----------
  ALLOCA_LIES_SO_USE_GETSP macro is obsolete [ci skip]

It has been superseded by ALLOCA_LIES_SO_SETSP_BEFORE_CALL
Since http://source.squeak.org/VMMaker/VMMaker.oscog-nice.2038.diff

Efforts are made for recognizing the cases when this macro is necessary directly from within the header
So the knowledge is gathered in the header (generated from preambleCode method in VMMaker)
It's maybe not ideal, nor fitting the modern trend.
But it's not worse than incomplete knowledge spreaded around configure/makefile/cmake/...

The STACK_ALIGN_BYTES macro also have been refactored so that header be autonomous.

Thus don't keep obsolete comments in the Makefiles.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.