[Vm-dev] Missing requirements for libBochsIA32Plugin on Osx32 pharo builds

[Eliot Miranda]

Hi Guille,

> On Jan 16, 2019, at 4:33 AM, Guillermo Polito <guillermopolito at gmail.com> wrote:
> 
> Hi Eliot,
> 
> Ci builds for Pharo are failing on Osx
> 
> https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/480327959?utm_source=github_status&utm_medium=notification
> 
> The problem seems to come from a missing requirement to build libBochsIA32Plugin.dylib, which makes the build of the librar to be skipped, and subsequently the VM build to fail.

That’s not the problem :-). The problem is that the build does not decide not to build libBochsIA32Plugin because the prerequisites are not present but instead fails.

Please read my message asking to add the plugins to plugins.ext and read the Mac makefiles in their treatment of the PREREQUISITES variable.  Those makefiles (and the other platform makefiles/autoconf scripts) are written to /not/ build the processor plugins unless the prerequisites have been built.

So the build specs, if they pay attention to plugins.ext, also need to pay attention to PREREQUISITES and not build any plugin which has any missing prerequisite.  Or if the build specs do not pay attention to plugins.ext, should simply exclude the processor plugins.

I did try and explain this in my message asking permission to add the processor plugins to plugins.ext.  I am sorry if my language is not clear.  Did I not communicate clearly or did you read superficially or...?  I want to understand so that we may communicate more effectively in the future and you not waste time encountering errors like this.


Cheers, (sincerely)
Eliot

> 
> /Applications/Xcode.app/Contents/Developer/usr/bin/make BUILD=build \
> -f /Users/travis/build/OpenSmalltalk/opensmalltalk-vm/platforms/iOS/plugins/BochsIA32Plugin/Makefile MAKEFILE=/Users/travis/build/OpenSmalltalk/opensmalltalk-vm/platforms/iOS/plugins/BochsIA32Plugin/Makefile \
> CONFIGURATION=product ARCH=i386 \
> PLATDIR=../../platforms PLUGINSRCDIR=../../src/plugins VMSRCDIR=../../spursrc/vm \
> LIBNAME=libBochsIA32Plugin COGDEFS="-DPharoVM=1" \
> APP=Pharo.app VM=Pharo BLDDIR=build USEPLUGINASDYLIB=TRUE \
> THIRDPARTYOUTDIR=/Users/travis/build/OpenSmalltalk/opensmalltalk-vm/.thirdparty-cache/macOS/i386 \
> \
> build/vm/libBochsIA32Plugin.dylib
> $(LIBNAME): libBochsIA32Plugin
> ../common/Makefile.plugin:238: build/vm/libBochsIA32Plugin.dylib has missing prerequisites. Not building.
> echo >build/vm/libBochsIA32Plugin.ignore
> cp -p build/vm/libBochsIA32Plugin.dylib Pharo.app/Contents/MacOS/Plugins
> cp: build/vm/libBochsIA32Plugin.dylib: No such file or directory
> make: *** [Pharo.app/Contents/MacOS/Plugins/libBochsIA32Plugin.dylib] Error 1
> 
> I see that the same in squeak builds just keeps going.
> Some difference in the makefiles? Any idea?
> 
> Thanks,
> Guille
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20190116/86ff4625/attachment.html>