[Vm-dev] VM Maker: ImageFormat-dtl.39.mcz

[commits at source.squeak.org]

David T. Lewis uploaded a new version of ImageFormat to project VM Maker:
http://source.squeak.org/VMMaker/ImageFormat-dtl.39.mcz

==================== Summary ====================

Name: ImageFormat-dtl.39
Author: dtl
Time: 21 July 2019, 6:27:30.136 pm
UUID: 0a6c5e4a-50d1-4d6d-b121-d1f98685c909
Ancestors: ImageFormat-dtl.38

Tidy up some explanatory comments in unit test.

=============== Diff against ImageFormat-dtl.38 ===============

Item was changed:
  ----- Method: ImageFormatTest>>testAllNewFromParameters (in category 'testing') -----
  testAllNewFromParameters
  
  	"ImageFormat knownVersionNumbers ==> #(6502 6504 6505 6521 7033 68000 68002 68003 68004 68019 68021 68533)"
  
  	"6502"
  	self assert: 6502 equals: (ImageFormat
  			wordSize: 4
  			closures: false
  			cog: false
  			spur: false
  			requiresNewSpur64TagAssignment: false
  			multipleBytecodes: false) asInteger.
  	"6504"
  	self assert: 6504 equals: (ImageFormat
  			wordSize: 4
  			closures: true
  			cog: false
  			spur: false
  			requiresNewSpur64TagAssignment: false
  			multipleBytecodes: false) asInteger.
  	"6505"
  	self assert: 6505 equals: (ImageFormat
  			wordSize: 4
  			closures: true
  			cog: true
  			spur: false
  			requiresNewSpur64TagAssignment: false
  			multipleBytecodes: false) asInteger.
  	"6521"
  	self assert: 6521 equals: (ImageFormat
  			wordSize: 4
  			closures: true
  			cog: true
  			spur: true
  			requiresNewSpur64TagAssignment: false
  			multipleBytecodes: false) asInteger.
  	self should: [ImageFormat
  			wordSize: 4
  			closures: true
  			cog: true
  			spur: true
  			requiresNewSpur64TagAssignment: true "should be false for 32 bits, this was a fix for 64 bit format numbers only"
  			multipleBytecodes: false]
  		raise: Error
  		whoseDescriptionIncludes: 'invalid format number 6523'
  		description: 'requiresNewSpurt64TagAssignment should be false for 32 bits, this was a fix for 64 bit format numbers only'.
  	"7033"
  	self assert: 7033 equals: (ImageFormat
  			wordSize: 4
  			closures: true
  			cog: true
  			spur: true
  			requiresNewSpur64TagAssignment: false
  			multipleBytecodes: true) asInteger.
  	self should: [ImageFormat
  			wordSize: 4
  			closures: true
  			cog: true
  			spur: true
  			requiresNewSpur64TagAssignment: true
  			multipleBytecodes: true]
  		raise: Error
  		whoseDescriptionIncludes: 'invalid format number 7035'
  		description: 'requiresNewSpurt64TagAssignment should be false for 32 bits, this was a fix for 64 bit format numbers only'.
  	"68000"
  	self assert: 68000 equals: (ImageFormat
  			wordSize: 8
  			closures: false
  			cog: false
  			spur: false
  			requiresNewSpur64TagAssignment: false
  			multipleBytecodes: false) asInteger.
  	"68002"
  	self assert: 68002 equals: (ImageFormat
  			wordSize: 8
  			closures: true
  			cog: false
  			spur: false
  			requiresNewSpur64TagAssignment: false
  			multipleBytecodes: false) asInteger.
  	"68003 is valid but has never been implemented"
  	self assert: 68003 equals: (ImageFormat
  			wordSize: 8
  			closures: true
  			cog: true
  			spur: false
  			requiresNewSpur64TagAssignment: false
  			multipleBytecodes: false) asInteger.
+ 	"68004 is valid but has never been implemented.
+ 	For pre-Spur, 68003 would probably be the preferred format
+ 	number choice, but either would be fine."
+ 	self assert: 68004 equals: (ImageFormat
- 	"68004 FIXME should not be allowed"
- 	self assert: 68004 equals: (ImageFormat "FIXME"
  			wordSize: 8
  			closures: true
  			cog: false
  			spur: false
  			requiresNewSpur64TagAssignment: true
  			multipleBytecodes: false) asInteger.
  	"68019 is valid but obsolete, replaced by 68021"
  	self assert: 68019 equals: (ImageFormat
  			wordSize: 8
  			closures: true
  			cog: true
  			spur: true
  			requiresNewSpur64TagAssignment: false
  			multipleBytecodes: false) asInteger.
  	"68021"
  	self assert: 68021 equals: (ImageFormat
  			wordSize: 8
  			closures: true
  			cog: true
  			spur: true
  			requiresNewSpur64TagAssignment: true
  			multipleBytecodes: false) asInteger.
  	"68531 is not used"
  	self should: [ImageFormat
  			wordSize: 8
  			closures: true
  			cog: true
  			spur: true
  			requiresNewSpur64TagAssignment: false
  			multipleBytecodes: true]
  		raise: Error
  		whoseDescriptionIncludes: 'invalid format number 68531'
  		description: '68531 is obsolete, use 68533 instead'.
  	"68533"
+ 	self assert: 68533 equals: (ImageFormat
- 	self assert: 68533 equals: (ImageFormat "FIXME pick one please"
  			wordSize: 8
  			closures: true
  			cog: true
  			spur: true
  			requiresNewSpur64TagAssignment: true
  			multipleBytecodes: true) asInteger.
  
  
  	
  
  !