[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] OSCogVM source as per VMMaker-oscog.54. (a4a7841)

[Nicolas Cellier]

Hi Eliot,
I will remove the translation to mac-roman, it's just that these dirty
corners speed my progression down.
If i understand correctly, either the legacy polling API is not
internationalization friendly, or maybe the wParam does contain someting
else than utf32/ucs4 code? Do we really need to support legacy polling API?
Sharing platform code forever with old VM is not sustainable, it
complexifies everything, IMO we have a license to cut useless code.

Le mer. 12 juin 2019 à 03:39, Eliot Miranda <notifications at github.com> a
écrit :

> Hi Nicolas,
>
> it's put code. Why not just fix it?
>
> On Tue, Jun 11, 2019 at 2:40 PM Nicolas Cellier <notifications at github.com>
> wrote:
>
> > I'm somehow amazed to not see a keymap[wParam & 0xff] buffer overrun
> > protection here!
> > This code is probably never executed since the image side presumably
> > provide a non NULL inputSemaphoreIndex, but it's scary.
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <
> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a4a7841030a5e4736452282d6e71ffe624a76267?email_source=notifications&email_token=ADY5VUEFXNWVU5PSQB5VXCTP2ALUPA5CNFSM4HXDSVUKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBAKSFO#commitcomment-33900718
> >,
> > or mute the thread
> > <
> https://github.com/notifications/unsubscribe-auth/ADY5VUCPLK4B7UBYBTM4ZWLP2ALUPANCNFSM4HXDSVUA
> >
> > .
> >
>
>
> --
> _,,,^..^,,,_
> best, Eliot
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a4a7841030a5e4736452282d6e71ffe624a76267?email_source=notifications&email_token=AAFRYIQWUXJJ72IA2SUNXELP2BHU3A5CNFSM4HXDSVUKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBAKVEL#commitcomment-33903755>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAFRYIW3TBYQSMUTZVDSQILP2BHU3ANCNFSM4HXDSVUA>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a4a7841030a5e4736452282d6e71ffe624a76267#commitcomment-33905496
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20190611/cf156654/attachment.html>