[Vm-dev] Some more effort to make Slang and VMMaker work on Pharo [for review]

[David T. Lewis]

Hi Guille,

On Tue, May 07, 2019 at 03:36:32PM -0700, Eliot Miranda wrote:
>  
> Hi Guile,
> 
> On Tue, May 7, 2019 at 2:28 AM Guillermo Polito <guillermopolito at gmail.com>
> wrote:
> 
> >
> > Hi all,
> >
> > In the last couple of days I've worked a bit on making VMMaker work in
> > Pharo again, based on the original effort of Eliot. I've produced a couple
> > of patches that I've left in the VMMaker inbox (below I past the commits'
> > info).
> >
> > With these changes I was able to generate, compile and run successfully so
> > far the Stack VM on OSX (mojave). I've tried it with opensmalltalk-vm's
> > platform code commit a838346b1, which is a commit previous to the migration
> > to Metal.
> >
> > To make this work I've written some tests too. I've packaged them so far
> > in a separate package (VMMaker-Tests). I've seen that currently VMMaker
> > tests are inside the VMMaker package itself, but some of them are red in
> > Pharo. I can move those tests to the VMMaker package itself if people see a
> > value on them.
> >
> > In any case, I'm just submitting this for review :).

Thank you for doing this :-)


> >
> > Cheers,
> > Guille
> >
> >
> In VMMaker.oscog-GAP.2533 I would prefer to see printString instead of
> asString.  asString is a horrible hack.  printString says what we mean.
> 
> ==== Patch 1 ====
> > Name: VMMaker.oscog-GAP.2533
> > Author: GAP
> > Time: 7 May 2019, 10:57:16.034354 am
> > UUID: 3209319f-60f3-4586-8d03-cfac3c9fddee
> > Ancestors: VMMaker.oscog-eem.2532
> >
> > Convert numeric constants to strings for concatenation.
> > Required for Pharo compatibility, where the arguments of concatenation are
> > not automatically coerced to strings.
> >
> 
> I trust you on these.  I'm not really in a position to test this out right
> now.  I suggest you push the  VMMakerCompatibilityForPharo6 packages to
> VMMaker as soon as you'd like.  You can write VMMaker right?
> 

+1

Guille, if you want commit access to the repo, you can make an account
on source.squeak.org and I'll add you the the VMMaker project. Or if
it's easier, just say which packages you are ready to move and either
I or Eliot (or any of the others with commit access) will move it to
VMMaker for you.

I note that VMMaker.oscog-GAP.2533 package is part of the main
VMMaker.oscog package. If you need to have that tested on Squeak I
can probably do that for you within the next couple of days if no
one else gets to it first.

Thank you!

Dave