[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Fix #484 [Win64]Cannot save and load image files with a heap whose size is more than 0xff ff ff ff (~4.1GB) (#485)

Vincent Blondeau notifications at github.com
Sat Apr 11 19:26:54 UTC 2020


The problem is actually when there is only one segment of memory of more of 0xff ff ff ff to read or to write to disk.

This fix the issue and it is tested with a real case on windows.

I added some checks on function return.

Let me know if changes are to be done to follows some conventions or optimizations. 
You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/485

-- Commit Summary --

  * Fix Issue when opening heaps of more than MAX DWORD size
  * Add function return test

-- File Changes --

    M platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c (48)

-- Patch Links --

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/485.patch
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/485.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/485
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200411/42cc3c8d/attachment.html>


More information about the Vm-dev mailing list