[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 536a6b: Hot fix for issue #488 Win32 DateAndTime

[Nicolas Cellier]

  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 536a6b7b01361bafae3d057a1498b7dfd6aa82b7
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/536a6b7b01361bafae3d057a1498b7dfd6aa82b7
  Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
  Date:   2020-04-25 (Sat, 25 Apr 2020)

  Changed paths:
    M platforms/minheadless/windows/sqWin32Heartbeat.c
    M platforms/minheadless/windows/sqWin32Time.c
    M platforms/win32/vm/sqWin32Heartbeat.c
    M platforms/win32/vm/sqWin32Time.c

  Log Message:
  -----------
  Hot fix for issue #488 Win32 DateAndTime

I broke it in https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9d52fef2240b7bdf6cfa1a7d6cf8c967220f0e85
While at it, fix the 4 copies of the function (without an IDE, I lost quite some time inspecting the wrong one!).


  Commit: 61862f35af63f088ddecc49717fce3367c5250e0
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/61862f35af63f088ddecc49717fce3367c5250e0
  Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
  Date:   2020-04-25 (Sat, 25 Apr 2020)

  Changed paths:
    M platforms/Cross/vm/sq.h
    M platforms/Cross/vm/sqVirtualMachine.c
    M platforms/Cross/vm/sqVirtualMachine.h
    M platforms/Mac OS/vm/sqMacTime.c
    M platforms/minheadless/common/sqaio.h
    M platforms/minheadless/generic/sqPlatformSpecific-Generic.c
    M platforms/minheadless/unix/sqUnixHeartbeat.c
    M platforms/minheadless/windows/sqWin32Heartbeat.c
    M platforms/minheadless/windows/sqWin32Time.c
    M platforms/unix/vm/sqUnixHeartbeat.c
    M platforms/unix/vm/sqUnixITimerHeartbeat.c
    M platforms/unix/vm/sqUnixITimerTickerHeartbeat.c
    M platforms/unix/vm/sqaio.h
    M platforms/win32/vm/sqWin32Heartbeat.c
    M platforms/win32/vm/sqWin32Time.c

  Log Message:
  -----------
  Function return type should not be declared volatile

Only lvalue can be volatile.
Eventually, a function can return a pointer to a volatile, but not a volatile (r)value
At best, it does nothing, at worse it will cripple the compile LOG with warnings.
See -Wignored-qualifiers of gcc or clang


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/c0f63984a22e...61862f35af63