[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

[David Stes]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Hi,

I tested the following, with a VM compiled from the sqUnixXdnd branch:

# git remote -v
origin	https://github.com/LinqLover/opensmalltalk-vm.git (fetch)
origin	https://github.com/LinqLover/opensmalltalk-vm.git (push)
# git branch
  Cog
* sqUnixXdnd

Tested:

1.    drag a file over the image, but do not drop it, then drag it away - does the image still work?

Yes it works , the cursor temporarily changes to a 'drag with +' sign when,
I drag the file1 over the VM display, and drag it away (without drop),
and the Squeak VM continues to function.

2.    after that, drag another file into the image and drop it - is the correct file displayed?

Yes, I think so.  I have files file1 and file2 and first drag file1 without
drop, and then I drag file2, when I drop file2 it displays the file2 path.

3.    try to drag some text into the image - this attempt should be rejected but the image should still accept other files after that

The cursor changes again to a drag with "+" sign but when I drop the text,
which I drag out of an external text editor, nothing seems to happen in Squeak.

The image continues to accept other files after that.

What also seems to work for me is to drag a folder (directory) into Squeak.
I get some sort of Unix file browser for the files/directories in that folder
(in Squeak).

I think it is an interesting PR (pull request).

But basically I don't understand what you are trying to fix.

But obviously there must exist bugs in there ...

However basically you seem to be "cleaning up" while I don't understand
what effective bug you are trying to fix.

Regards,
David Stes


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfPAlVAAoJEAwpOKXMq1MaFXkIAMA8YImzs9vBj7J68M3guJdS
+TfyKqjYaPJI6Vy+bcBeZxj9D2DlpqxG0AH/hRdccAFQ+iucql+ohJC4CeQ4CLT1
PlQjUfQO0XtShAkWCf1XP90PMbjaXZcnPfgCHCzC4XiDe09AVUeCSc0acwdg8JRe
ZGkcWt/r+HxRVvLyAr83JcNRyUQwei5U3pf5LS5v/QLv1WeqdKZJPLfTbYg+VDVZ
R0SZICNldynYBD1RInaiFiiwNknOI/CryAF8w/yj4zPV3trNDh3d54Yu1bgHdfj/
J05AD4vhGYNfUTzx+mn0Kz2vqb5k1RKWDgVX8yFJWI3cgqtTMjpcq0R0VBd7LFo=
=lLKy
-----END PGP SIGNATURE-----

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675600441
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200818/bf04d166/attachment-0001.html>