[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] DropPlugin: Unify numFiles fallback value before DragDrop has been recorded (#514)
notifications at github.com
Wed Aug 19 11:56:03 UTC 2020
This PR aligns the default `numFiles` value recorded for `DragEnter`, `DragMove`, and `DragLeave` events recorded by the X11 implementation of the DropPlugin, which was `1`, to the default value used by the Win32 implementation of the plugin, which is `0`.
The motivation for this change is to unify the event protocol along with different platforms. It would technically be highly expensive and questionable to find out this value before the drop event has been recorded. Concretely, Win32 does not support this at all without switching the library, and on Linux, this would require a performance-extensive ping-pong of "Target to source: Please hand a copy of all dragged files", "Source to target: I converted these files for you", "Target to source: Thank you, but I was only interested into their total number" messages. (However, interestingly macOS appears to support this (I could not yet test it) and https://github.com/codefrau/SqueakJS/ could do so, too.)
While pursuing the same master plan, this PR is not dependent nor reverse-dependent on #508. They can be merged independently of each other.
Please review and merge if you agree. I hereby confirm that I did not observe any regressions when dragging files or folders into a recent Squeak image.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* X11 DropPlugin: Don't specify numFiles= 1 before DragDrop
-- File Changes --
M platforms/unix/vm-display-X11/sqUnixXdnd.c (14)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Vm-dev