[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

[David Stes]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


First of all, sorry if you receive this multiple times,
most likely this is because I click the "Comment" button multiple times.

OK, I modified the HandMorph -> private events -> generateDropFilesEvent:
as you indicated, from the Squeak6.0alpha-19793-64bit.image for the tests.

I also tried with Squeak 4, 
I have the same result when I try with the Squeak4.6-15012 (Squeak 4 VM).

When I drag and drop a file "myfile" into the Squeak window,
the Transcript shows:

1
2
2
...
2
2
3
4
3

and the object for "myfile" is created.

If I drag "myfile" into the Squeak window and then out of it (without drop):

1
2
2
...
2
2
3

On the other hand if I use the VM, with this pull request, compiled :

First when drag and drop "myfile" :

1
2
2
...
2
2
4

Then when dragging "myfile" without drop :

1
2
2
...
2
2
3

So this confirms what you described ...

However to really test this pull request I think it is required to test 
the code (changeset) which you are planning to put into the "inbox".

Maybe I missed something  but in the description of this pull request,
you could give a pointer to the changeset you are developing.

Maybe if I can download it from some place, I can test it.

I now realise that you are actually talking about a combination of 2 things.

  1. a change in the VM
  2. a changeset of some Squeak code that depends on that the VM change

Correct ?

If so, I'd certainly would be interested in trying out the changeset.

Regards,
David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfPVl3AAoJEAwpOKXMq1MaVr8IAJLUPrZgBudoLM5GR7owR0/4
/vev7wuQvttCw3Sn1ib/G3podJywutiErXdugX3tA28hqyQvY9bFLzHK1+JjDyL1
ALhyg+uPzl+KOwtVEKBkAF2HO7dokDnr9eFIrSZyc917tb5IqnFW1yOBCdeVXqkn
JCCIi0nmU4psafmdEk8gVbQb4PdkNtdrgSck1GO1N2VyAkhiHyMNv+dJZs3ES2NZ
Id+t0+k3V1er5TJRnaOJj5vBluutMZqTD5yk4iZ1UGcR12wLgKGxENnFgLeIpPK0
WQI/0oHZUx8V5sP5id215U9bt/SkT8IXoDGQ54LC8Clv9JOjP6SkUH3K4j54Cs8=
=a1r+
-----END PGP SIGNATURE-----


-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-676543318
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200819/c821e1d1/attachment.html>