[Vm-dev] Errored: OpenSmalltalk/opensmalltalk-vm#1942 (Cog - 015d381)

[Travis CI]

Build Update for OpenSmalltalk/opensmalltalk-vm
-------------------------------------

Build: #1942
Status: Errored

Duration: 1 hr, 55 mins, and 26 secs
Commit: 015d381 (Cog)
Author: Nicolas Cellier
Message: Fix some Squeak3D UB: shifting left some negative int

A reproducible case of crash provided by Stephane Rollandin gives the following warning with clang `-fsanitize=undefined`:

>../../platforms/Cross/plugins/Squeak3D/b3dMain.c:1252:29: runtime error: left shift of negative value -760
>../../platforms/Cross/plugins/Squeak3D/b3dMain.c:1254:25: runtime error: left shift of negative value -751
>../../platforms/Cross/plugins/Squeak3D/b3dDraw.c:317:33: runtime error: left shift of negative value -802
>../../platforms/Cross/plugins/Squeak3D/b3dDraw.c:318:33: runtime error: left shift of negative value -802
>../../platforms/Cross/plugins/Squeak3D/b3dDraw.c:316:33: runtime error: left shift of negative value -114
>../../platforms/Cross/plugins/Squeak3D/b3dMain.c:829:61: runtime error: left shift of negative value -2

On OSX optimized VM, a crash happens in b3dMain.c, in function b3dAddBackFill at line 994 soon after those warnings
By protecting the shift with (unsigned) cast, this particular crash disappear.

There is still other crash happening related to bad fill list, but one thing at a time...

View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/0f974af6a09c...015d381da7b5

View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/647839209?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200208/8fc01efd/attachment.html>