[Vm-dev] Errored: OpenSmalltalk/opensmalltalk-vm#1943 (Cog - 36a1f1e)

[Travis CI]

Build Update for OpenSmalltalk/opensmalltalk-vm
-------------------------------------

Build: #1943
Status: Errored

Duration: 56 mins and 25 secs
Commit: 36a1f1e (Cog)
Author: Nicolas Cellier
Message: Workaround a Squeak3D crash

After proper instrumentation, it appears that a reproducible crash case provided by Stephane Rollandin is due to attempt of removing a face which is not in the fillList.
This happens in the special case when `leftEdge == lastIntersection`, and the code attempts to remove `leftEdge->rightFace` which seem to not always be on the fillList.
It's not obvious to understand if this is really an invariant of the loop, or a wrong expectation.
Thus, as a workaround, protect the removal by a preliminary inclusion test.

Note that removing or adding a face should change its `B3D_FACE_ACTIVE` flags.
Normally, we remove then add, so do not have to toggle the flag.
But if we do not remove, then we must toggle, otherwise another invariant will break and cause crash in `b3dToggleTopFills`.

View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/015d381da7b5...36a1f1e2ef63

View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/648005026?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200209/4b9ea0b9/attachment.html>