[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Fix issue #472 (#473)

Eliot Miranda notifications at github.com
Wed Jan 22 02:52:56 UTC 2020


Hi Nicolas,

    we trust you and with git's merge capability conflicts are unlikely.
So why not do this on the main branch? I'm curious why you're doing this
work on a branch...

On Tue, Jan 21, 2020 at 9:42 AM Nicolas Cellier <notifications at github.com>
wrote:

> when i == j, there is nothing to sort.
> If we call this for the first time, there is no stack allocated by INIT(0),
> but stack is accessed nonetheless thru PUSH(i,j).
> The best thing todo IMO is to return early.
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/473
> Commit Summary
>
>    - Fix issue #472
>
> File Changes
>
>    - *M* platforms/Cross/plugins/Squeak3D/b3dInit.c
>    <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/473/files#diff-0>
>    (6)
>
> Patch Links:
>
>    - https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/473.patch
>    - https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/473.diff
>
>> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/473?email_source=notifications&email_token=ADY5VUCO6Q3K7YJ6NXWSUY3Q64XXXA5CNFSM4KJXN4FKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IHWSHIQ>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ADY5VUDMGEOQGTCR2MOTKJ3Q64XXXANCNFSM4KJXN4FA>
> .
>


-- 
_,,,^..^,,,_
best, Eliot


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/473#issuecomment-576984097
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200121/9644eded/attachment.html>


More information about the Vm-dev mailing list