[Vm-dev] VM Maker: VMMaker.oscog-nice.2761.mcz

[Nicolas Cellier]

Le mar. 23 juin 2020 à 19:52, Eliot Miranda <eliot.miranda at gmail.com> a
écrit :

>
> Hi Nicolas,
>
>    I think my concern about globals can be handled with an assert, because
> the problem looks like it never happens in practice.
>
> I see this as a result of the changes:
>
> -       mcpc = ((cogMethod->cpicHasMNUCaseOrCMIsFullBlock)
> -               ? (((usqInt)cogMethod)) + cbNoSwitchEntryOffset
> -               : (((usqInt)cogMethod)) + cmNoCheckEntryOffset);
> +       if ((cogMethod->cpicHasMNUCaseOrCMIsFullBlock)) {
> +               mcpc = (((usqInt)cogMethod)) + cbNoSwitchEntryOffset;
> +       }
> +       else {
> +               mcpc = (((usqInt)cogMethod)) + cmNoCheckEntryOffset;
> +       }
>
> This is undesirable.  I'm going to try and undo this part of the change.
>
>
Indeed, it's the case when all branches assign to the same variable.
Can't we recognize it properly?
Let me have a look...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200623/86b08ed3/attachment.html>