[Vm-dev] Windos UNICODE (?!?!?)

[Nicolas Cellier]

+1

I think we already have done most of the work to enable this... minheadless
is UNICODE already.

Le ven. 8 mai 2020 à 09:23, Tobias Pape <Das.Linux at gmx.de> a écrit :

>
> Hi
>
> I think we ought to define UNICODE and _UNICODE.
> -t
>
> > On 08.05.2020, at 09:14, Marcel Taeumel <marcel.taeumel at hpi.de> wrote:
> >
> > ...on second thought: I might be better to first find all non-unicode
> calls, convert them, make sure everything works, then enable that UNICODE
> flag, and finally change all explicit unicode calls to "transparent" ones.
> :-)
> >> Am 08.05.2020 09:03:40 schrieb Marcel Taeumel <marcel.taeumel at hpi.de>:
> >>
> >> Hi Eliot,
> >>
> >> I suppose we decided to make explicit use of the unicode functions. See
> https://devblogs.microsoft.com/oldnewthing/?p=40643 -- Maybe this is from
> a time when our source held both ANSI and UNICODE variants. These days, we
> could simplify the code by defining -DUNICODE=1 and skip using, e.g.,
> "GetWindowTextW" because then "GetWindowText" will automatically choose the
> unicode versions.
> >>
> >> I think that that -DUNICODE has never been part of some makefile.
> >>
> >> Best,
> >> Marcel
> >>> Am 07.05.2020 23:09:23 schrieb Eliot Miranda <eliot.miranda at gmail.com
> >:
> >>>
> >>> Hi All, especially Windows persons,
> >>>
> >>> I'm debugging the 64-bit VM in the context of Perf on win64. I've
> >>> just noticed that we don't appear to be building a UNICODE VM?!?! I
> rind
> >>> no define of UNICODE in the win32 platform files and no define of
> UNICODE
> >>> on the compiler command line in the build.winXXxYY/common makefiles.
> This
> >>> is surely a mistake, isn't it? If this is a regression, when and why
> did
> >>> this occur? I'm going to add -DUNICODE=1 to the Makefile.msvc
> makefiles.
> >>> AFAICT this should also happen with the Cygwin Makefiles. But before I
> >>> make changes that could affect lots of people I thought I should ask
> here.
> >>> Anyone know when and why we dropped -DUNICODE from the Cygwin build
> command
> >>> line?
> >>>
> >>> _,,,^..^,,,_
> >>> best, Eliot
> >>> Hi All, especially Windows persons,
> >>>
> >>>    I'm debugging the 64-bit VM in the context of Perf on win64.  I've
> just noticed that we don't appear to be building a UNICODE VM?!?!  I rind
> no define of UNICODE in the win32 platform files and no define of UNICODE
> on the compiler command line in the build.winXXxYY/common makefiles.  This
> is surely a mistake, isn't it?  If this is a regression, when and why did
> this occur?  I'm going to add -DUNICODE=1 to the Makefile.msvc makefiles.
> AFAICT this should also happen with the Cygwin Makefiles.  But before I
> make changes that could affect lots of people I thought I should ask here.
> Anyone know when and why we dropped -DUNICODE from the Cygwin build command
> line?
> >>>
> >>> _,,,^..^,,,_
> >>> best, Eliot
> >>>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200508/174db0e3/attachment-0001.html>