[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Bump minimal supported Windows version to Windows 8 (0x0602). (#499)

Nicolas Cellier notifications at github.com
Wed May 13 19:59:07 UTC 2020


@nicolas-cellier-aka-nice commented on this pull request.



> @@ -53,16 +53,17 @@ ifdef MSVC
 MEMACCESS:=-DUSE_INLINE_MEMORY_ACCESSORS=1
 endif
 
-# Set minimum version to WindowsXP (see /cygwin/usr/include/w32api/w32api.h)
-WINVER:=-D_WIN32_WINNT=0x0501 -DWINVER=0x0501
+# Set minimum version to Windows 8 (see /cygwin/usr/include/w32api/w32api.h)
+WINVER:=-D_WIN32_WINNT=0x0602 -DWINVER=0x0602

As suggested on the mailing list, I would just use 0x0600

See also https://docs.microsoft.com/en-us/cpp/porting/modifying-winver-and-win32-winnt?view=vs-2019 for the list of _WIN32_WINNT version.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499#pullrequestreview-411254502
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200513/3eb4043a/attachment.html>


More information about the Vm-dev mailing list