[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] primitives 54 and 554 for timesTwoPower: answer incorrect result on 64bits macOS VM (#383)

[Eliot Miranda]

Hi Nicolas, Tobias,

On Thu, May 14, 2020 at 12:47 PM Nicolas Cellier <notifications at github.com>
wrote:

> Eliot was working for providing native bit-identical floating point
> functions for Terf.
> So we would use the patched fdlibm once finished.
>

It seems to be ready to go.  All we do is define
BIT_IDENTICAL_FLOATING_POINT in the makefile.  In fact, it might be good to
invert things, and have this be the default unless one defines, e.g.
PLATFORM_SPECIFIC_FLOATING_POINT.  What do y'all think?

build.macos64x64$ diff squeak.cog.spur/Makefile croquet.cog.spur/Makefile
5a6,7
> BIT_IDENTICAL_FLOATING_POINT=BIT_IDENTICAL_FLOATING_POINT
>
8a11,17
> # Produce Croquet.app, CroquetAssert.app & CroquetDebug.app
> APPNAME:=Croquet
> APPNAMEDEF:=$(APPNAME)
> APPIDENTIFIER:=org.Croquet.$(APPNAME)
>
> CFLAGS:=-DCROQUET=1
>
11c20
< include ../common/Makefile.app.squeak
---
> include ../common/Makefile.app

_,,,^..^,,,_
best, Eliot


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/383#issuecomment-628855177
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200514/4a8339be/attachment.html>