[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Unix(macOS) SocketPlugin: (7deac02)

Holger Freyther notifications at github.com
Sat Oct 10 04:25:58 UTC 2020


> Hi Holger, first I don’t do anything. This code is historical. I’m simply trying to understand it and fix it. Second, the reason it’s 1 is that it’s testing for writability of a single file descriptor which happens to be that of a socket.


The commit that replaced `select(s+1,` with `select(1` seemed to have your name associated with it. I am sorry if I wrongly attributed this change to you. Calling the parameter "nfds" in the manpage is misleading and I wanted to probe if it was intentional that we set the "highest fd set in the fdset" to 0 (e.g. stdin) while the debug output showed fd numbers such as 18, 19.

But great that we resolved that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/7deac028aeeb769c8782242fc23bebdfaaa58e3d#commitcomment-43124918
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20201009/68cf73b6/attachment.html>


More information about the Vm-dev mailing list