[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] configure script : check for <ifaddrs.h> (#523)

[dcstes]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Any feedback please ?

The change to use <ifaddrs.h> only if the build target has it,
seems a logical change ...

The only risk is perhaps that somebody unintentionally re-enables the 
'old code' by not defining HAVE_IFADDRS_H in their Makefile or config.h.

This is because by default

#undef HAVE_IFADDRS_H

and that will thus by default enable the 'old code'.

While the default now is to enable the 'new code' which uses <ifaddrs.h>.

But this can easily be solved by requiring to #define HAVE_IFADDRS_H,
and the 'configure' script will do just that automatically if it finds the file.

Anyway -- with this patch the current COGVM compiles on Solaris 10.

By the way Solaris 10 still uses openssl 0.9.7 and I think the configure
quite correctly disables SSL support so that works fine.

The SSL plugin is not built I think on Solaris 10, but no problem.

The real interest is in the support for Solaris 11 with openssl 1.0.2 etc.,
but it is nice that the code still compiles on Solaris 10.

Regards,
David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfbZoGAAoJEAwpOKXMq1MaO3sH/26aTh31X//H3xC/bQn+jPdK
ES/YFfFXJ/OB9i/WroLia8n4IHpoPCguwdLy5NPtMbo30s8VpQeVWe2OAun+jLOX
Ekj9LbfFbKpAftetgD7O+2ONWmbikvx1nrPcl4qfkD1rcf1m+ESbftsf69vDvIrc
rNC+Bgq4ZR84yQIxOySzZskN34mtPQfdOxw2B1JQP1cTtPvynkiBy+fGFM2m8Y3J
7StRLKQx9q4dzI875xV3Vmd9gmhFxA4MNHMOmh1i4r9rZYbrQjCtaoHnuI9abQcf
jPKI01K11kyj80aZlV3h9oaslTJnEIGWhJkHFYjQBamVJcqbj2wvYLCiwc9WHIY=
=lu3K
-----END PGP SIGNATURE-----


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/523#issuecomment-698768019
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200925/14a8a882/attachment.html>