[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Inlcude the Squeak headers after the C headers. This hsould also help fix (47b8d52)

Tobias Pape notifications at github.com
Mon Sep 28 10:06:47 UTC 2020


`./confiugre` set the `CFLAGS` accordingly.
Yes, via cmdline means.
That's why I said “ as little defines […] as possible“
imho '-DHAVE_CONFIG_H" should be the only define besides Debug flags.


some makefile generators also are pretty good at also maintaining the debugflags, but that's out of scope here.

So something like
```C
#ifdef HAVE_CONFIG_H
#include "config.h"
#else
#error Please run WHATEVER_OUR_CONFIG_GENERATOR IS first
#endif
```

Which would fit nicely in either `sq.h`, or more appropriately probably in [`sqConfig.h`](https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/platforms/unix/vm/sqConfig.h#L3)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/47b8d5202b835b5d9d1556ed0cf0dda11e5b246c#commitcomment-42779032
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200928/d58f56f6/attachment.html>


More information about the Vm-dev mailing list