[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 133e6f: Fix the #define/#undef incantation on non spur VM ...

Nicolas Cellier noreply at github.com
Tue Jan 12 13:00:56 UTC 2021


  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 133e6ffe5def226ba4f0deb66a91e516b01662ec
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/133e6ffe5def226ba4f0deb66a91e516b01662ec
  Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
  Date:   2021-01-12 (Tue, 12 Jan 2021)

  Changed paths:
    M platforms/unix/vm/sqPlatformSpecific.h

  Log Message:
  -----------
  Fix the #define/#undef incantation on non spur VM (V3)

Those define are for a default implementation, but do we really use it?
Shouldn't it be protected by some USE_DEFAULT_ALLOCATION or something?


  Commit: 85fc1d429d232a790c6d8780c34cbb38692042ef
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/85fc1d429d232a790c6d8780c34cbb38692042ef
  Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
  Date:   2021-01-12 (Tue, 12 Jan 2021)

  Changed paths:
    M platforms/win32/vm/sqPlatformSpecific.h

  Log Message:
  -----------
  Replace stddef.h by string.h in win32 platform specifics

For some reasons, <corecrt.h> fails to compile on my machine, but <stddef.h> fails on the C.I.
The stack of uncompatible macros is getting really fragile...
This commit is only a wild guess.
IMO we should try and follow standards where possible.


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/31022381ed6d...85fc1d429d23


More information about the Vm-dev mailing list