[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Fix missing KeyRelease events when multiple keys are depressed. (#547)

Eliot Miranda notifications at github.com
Tue Jan 19 01:09:51 UTC 2021


@eliotmiranda commented on this pull request.

Hi David, I would bite the bullet and write an explicit initializer for lastKeyValue containing 256 -1's, get rid of the initialization lines in storeLastKeyValue (lines 1722 through 1727).  Looks perfect otherwise.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/547#pullrequestreview-570843625
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20210118/1cddcafb/attachment-0001.html>


More information about the Vm-dev mailing list