[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Nuke the now obsolete -sqMakeMemoryNotExecutableFromTo. Make sure that (1455c64)

Marcel Taeumel notifications at github.com
Wed Jul 7 14:45:35 UTC 2021


This function looks unfinished. "address" is not initialized but used as argument for sqAllocateMemorySegmentOfSizeAboveAllocatedSizeInto(). After removing "roundUpToPage" from "address", I could compile the VM, but it would not start. Looking at its sibling"sqAllocateMemory(), I think that there is some magic missing to calculate the minAddress to be provided into sqAllocateMemorySegmentOfSizeAboveAllocatedSizeInto(). Same for allocateJITMemory() in sqWin32Alloc.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1455c649198064291e379e553af0b37b712e5a72#commitcomment-53168950
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20210707/7f240af4/attachment.html>


More information about the Vm-dev mailing list