[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Fix include order (#562)

Marcel Taeumel notifications at github.com
Fri Jul 16 06:27:09 UTC 2021


So, I updated this PR to HEAD. I will merge this soon. Just testing MSVC builds now.

Some remaining quirks (using VMMaker.oscog-mt.2986 in VMMakerInbox, based in -nice.2957, also in inbox) are:
- "#include <asm/cachectl.h>" moves to the bottom in cogitMIPSEL.c
- Some hiccups (and extra type casts) regarding usqInt vs sqInt ... ? Maybe it is nothing, maybe there is some extra magic here during source generation that I am not aware of.

So, besides that include-order thingy in the VMMaker, there are only those extra HAVE_CONFIG_H in cross-platform sources:
platforms/Cross/plugins/B3DAcceleratorPlugin/sqOpenGLRenderer.c 
platforms/Cross/plugins/IA32ABI/xabicc.c
platforms/Cross/plugins/SoundCodecPrims/sqSoundCodecPluginBasicPrims.c
platforms/Cross/plugins/Squeak3D/b3dInit.c 
platforms/Cross/plugins/Squeak3D/b3dMain.c
platforms/Cross/plugins/SurfacePlugin/SurfacePlugin.c
platforms/Cross/vm/sqHeapMap.c
platforms/Cross/vm/sqVirtualMachine.c 

Platform-specific fixes considering HAVE_CONFIG_H:
platforms/unix/plugins/FileAttributesPlugin/faSupport.c 
platforms/unix/vm/aio.c 
platforms/unix/vm/sqUnixVMProfile.c 
platforms/win32/vm/sqPlatformSpecific.h 

And this:
platforms/unix/config/getversion.c
platforms/Cross/vm/sqSCCSVersion.h
platforms/Cross/vm/sqAssert.h 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/562#issuecomment-881210071
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20210715/4e0178b6/attachment.html>


More information about the Vm-dev mailing list