[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] windows: resync the VM time when the system clock gets changed (#588)

[Jakob Reschke]

@j4yk commented on this pull request.



> @@ -625,6 +625,10 @@ MainWndProcW(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
   case WM_KILLFOCUS:
     fHasFocus = 0;
     return DefWindowProcW(hwnd,message,wParam,lParam);
+
+  case WM_TIMECHANGE:
+    resyncSystemTime();
+

For what it is worth, wine has no default reaction to WM_TIMECHANGE https://github.com/wine-mirror/wine/blob/master/dlls/user32/defwnd.c

One might speculate whether Windows will in the future at some point have a meaningful default reaction to that message (which would speak for DefWindowProc). I doubt it will (which speaks for break).

But anyway I would not keep the fall-through because otherwise the next person to add a message here might overlook it and introduce unexpected behavior whenever WM_TIMECHANGE comes in.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/588#discussion_r700467291
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20210901/a8c0d5ef/attachment.html>