<br><br><div class="gmail_quote">On Sun, Mar 22, 2009 at 11:40 PM, Igor Stasenko <span dir="ltr"><<a href="mailto:siguctua@gmail.com">siguctua@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
2009/3/22 Igor Stasenko <<a href="mailto:siguctua@gmail.com">siguctua@gmail.com</a>>:<br>
<div class="im">> 2009/3/22 Michael van der Gulik <<a href="mailto:mikevdg@gmail.com">mikevdg@gmail.com</a>>:<br>
>><br>
>><br>
>><br>
>> On Sun, Mar 22, 2009 at 4:55 PM, Michael van der Gulik <<a href="mailto:mikevdg@gmail.com">mikevdg@gmail.com</a>> wrote:<br>
>>><br>
>>> <snip><br>
>>> >>> Hi VM guys.<br>
>>> >>><br>
>>> >>> Does anybody have any insights into the following?:<br>
>><br>
>> <bigger snip><br>
>><br>
>> I've isolated the bug. To reproduce, do the following in a disposable image:<br>
>><br>
>> Sensor primSetInputSemaphore: (Semaphore new).<br>
>><br>
><br>
> self<br>
> primSetInputSemaphore: (Smalltalk registerExternalObject: inputSemaphore).<br>
><br>
</div>That of couse is not excuse for VM crash, when you passing a semaphore<br>
object intead of valid smallinteger index in external objects table.<br>
It should check and fail if you do so.<br>
</blockquote></div><br>Thanks, Igor. I never was good at details.<br><br>When I next have time (Tuesday evening?) I'll submit a patch for this:<br><br>- rename primSetInputSemaphore: to primSetInputSemaphoreIndex:.<br>
- Add checks in the VM: must be a SmallInteger, must be a valid index in the external objects table, must point to a Semaphore.<br>- Add error handling code in the method itself.<br><br>Gulik.<br clear="all"><br>-- <br><a href="http://gulik.pbwiki.com/">http://gulik.pbwiki.com/</a><br>