<br><br><div class="gmail_quote">On Wed, Jul 1, 2009 at 10:02 AM, Nicolas Cellier <span dir="ltr"><<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
2009/7/1 David T. Lewis <<a href="mailto:lewis@mail.msen.com">lewis@mail.msen.com</a>>:<br>
<div class="im">><br>
> On Wed, Jul 01, 2009 at 08:32:18AM -0700, Andreas Raab wrote:<br>
>><br>
>> Ouch. Yeah, I'd say that's right...<br>
><br>
> This is from <a href="http://bugs.squeak.org/view.php?id=7260" target="_blank">http://bugs.squeak.org/view.php?id=7260</a>. I reopened the<br>
> issue on Mantis.<br>
><br>
> I'll apply the fix to VMMaker as soon as I can (but feel free to do the<br>
> update if I don't get to it first; Bert you have developer access as well<br>
> as Andreas of course).<br>
><br>
> Dave<br>
><br>
<br>
</div>Ouch again, my fault.<br>
How can the tests pass... Hmm not enough test?</blockquote><div><br></div><div>There are no > < >= or <= tests in the FloatTest class. I just read the draft IEEE 754 spec and didn't find it easy going so I'd much rather you wrote the tests than I :) I'm very happy to get them to pass.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><br>
<font color="#888888"><br>
Nicolas<br>
</font><div><div></div><div class="h5"><br>
>><br>
>> Bert Freudenberg wrote:<br>
>> ><br>
>> >I just noticed that<br>
>> ><br>
>> >bytecodePrimGreaterOrEqual<br>
>> > ...<br>
>> > aBool := self primitiveFloatLess: rcvr thanArg: arg.<br>
>> > successFlag ifTrue: [^self booleanCheat: aBool not].<br>
>> ><br>
>> >got changed to<br>
>> ><br>
>> >bytecodePrimGreaterOrEqual<br>
>> > ...<br>
>> > aBool := self primitiveFloatGreaterOrEqual: rcvr toArg: arg.<br>
>> > successFlag ifTrue: [^self booleanCheat: aBool not].<br>
>> ><br>
>> >but shouldn't that be<br>
>> ><br>
>> >bytecodePrimGreaterOrEqual<br>
>> > ...<br>
>> > aBool := self primitiveFloatGreaterOrEqual: rcvr toArg: arg.<br>
>> > successFlag ifTrue: [^self booleanCheat: aBool].<br>
>> ><br>
>> >and similarly for bytecodePrimLessOrEqual?<br>
>> ><br>
>> >- Bert -<br>
>> ><br>
>> ><br>
><br>
</div></div></blockquote></div><br>