<br><br><div class="gmail_quote">On Tue, Aug 18, 2009 at 5:05 AM, David T. Lewis <span dir="ltr"><<a href="mailto:lewis@mail.msen.com">lewis@mail.msen.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
VMMaker (from SqueakSource) can now be loaded into closure-enabled images.<br>
<br>
I was able to remove a couple of temp variables from the GeniePlugin<br>
primitive without affecting the logic. This was discussed on several<br>
lists back in May.<br>
<br>
The fix is in VMMaker-dtl.135 on SqueakSource, and is documented in<br>
Mantis <a href="http://bugs.squeak.org/view.php?id=7384" target="_blank">http://bugs.squeak.org/view.php?id=7384</a>.</blockquote><div><br></div><div>Thanks, Dave, that's great!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
<br>
Dave<br>
<div><div></div><div class="h5"><br>
On Mon, May 25, 2009 at 10:37:15PM -0400, David T. Lewis wrote:<br>
><br>
> On Mon, May 25, 2009 at 11:06:10AM -0700, Eliot Miranda wrote:<br>
> ><br>
> > On Mon, May 25, 2009 at 7:40 AM, David T. Lewis <<a href="mailto:lewis@mail.msen.com">lewis@mail.msen.com</a>> wrote:<br>
> ><br>
> > ><br>
> > > On Sun, May 24, 2009 at 01:44:52PM -0700, Eliot Miranda wrote:<br>
> > > ><br>
> > > > 3. refactor the GeniePlugin method into an outer args parser and an inner<br>
> > > > engine method and solve the problem. Since VMMaker will inline anyway<br>
> > > this<br>
> > > > shouldn't make performance worse. I haven't done this because I'm not<br>
> > > the<br>
> > > > author and it is quite a complex method.<br>
> > ><br>
> > > This sounds like the right thing to do, regardless of what may change<br>
> > > in the compiler(s).<br>
> ><br>
> ><br>
> > +1<br>
> ><br>
><br>
> Well unfortunately the refactoring turns out to be easier said than done.<br>
> At least it was easier for me to say it than it was for me to do it.<br>
><br>
> I made a naive attempt to split the primitive into smaller methods, but this<br>
> just ended up trading off too many things on the stack for too many arguments<br>
> in an argument list.<br>
><br>
> The method temp variables could be changed to be instance variables. This<br>
> would probably work fine for any current VMs (not sure about Hydra), but<br>
> it does not pass the smell test IMO.<br>
><br>
> I suspect that Nathaniel Schaerli knew what he was doing when he wrote<br>
> this primitive, and I most certainly do not, so I don't expect that I will<br>
> make much further progress on this front.<br>
><br>
> Dave<br>
</div></div></blockquote></div><br>