<br><br><div class="gmail_quote">On Tue, Jan 12, 2010 at 7:54 AM, Andreas Raab <span dir="ltr"><<a href="mailto:andreas.raab@gmx.de">andreas.raab@gmx.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
Igor Stasenko wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Btw, about that function. Its using a squeakFileOffsetType, which is<br>
platform specific, and i had hard times<br>
trying to deal with right header inclusion order imposing dependency<br>
of interpreter from platform code, which, IMO should be avoided.<br>
I propose to change it to<br>
typedef unsigned long long vmFileOffsetType;<br>
and use this type instead.<br>
</blockquote>
<br></div>
I'm not sure if MSVC supports long long nowadays. It didn't used to - it used to require __int64 which is why the definition of squeakFileOffsetType is external.<br></blockquote><div><br></div><div>We should just use usqLong. The platform-specific definition in platforms/Cross/vm/sqVirtualMachine.h can be moved to sqMemoryAccess.h so that usqLong & sqLong are also available once sqInt & usqInt are.</div>
<div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
Cheers,<br><font color="#888888">
- Andreas<br>
<br>
</font></blockquote></div><br>