<br><br><div class="gmail_quote">On Tue, Nov 9, 2010 at 7:30 PM, David T. Lewis <span dir="ltr"><<a href="mailto:lewis@mail.msen.com">lewis@mail.msen.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
On Mon, Nov 08, 2010 at 06:41:57PM -0800, Andreas Raab wrote:<br>
<div class="im">><br>
> On 11/8/2010 5:08 PM, Levente Uzonyi wrote:<br>
> >The problem is that the method expects ByteStrings as arguments, but it<br>
> >won't fail if one of them is a WideString. Instead it returns wrong<br>
> >results. Here's an example (in Squeak):<br>
> ><br>
> >ByteString new<br>
> >findSubstring: 'b'<br>
> >in: 'abc' asWideString<br>
> >startingAt: 1<br>
> >matchTable: ((0 to: 255) as: ByteArray). "===> 0"<br>
> ><br>
> >The result is 0, while it should be 2. The problem is worked around in<br>
> >Squeak by making sure that the primitive is not used in this case.<br>
> ><br>
> >'abc' asWideString<br>
> >findString: 'b'<br>
> >startingAt: 1<br>
> >caseSensitive: true. "===> 2"<br>
> ><br>
> >Though a naive user can still use the method as shown here.<br>
><br>
</div>> Thanks. Looks like a problem in extracting string arguments in<br>
> translated primitives. With Squeaksource being down again (should we<br>
> move VMMaker to <a href="http://source.squeak.org" target="_blank">source.squeak.org</a>?) I've attached a change set with a<br>
> fix. This adds an additional check for char* arguments in translated<br>
> prims to ensure that they're actually byte objects.<br>
<br>
Andreas,<br>
<br>
Your fix does indeed resolve the underlying problem. I added it<br>
to VMMaker (with a note to Eliot to do likewise with oscog), and<br>
also added unit tests based on Levente's example. This should<br>
allow the various WideString workarounds to be removed once the<br>
updated VMs are in circulation.<br></blockquote><div><br></div><div>OK, it's in my working version. It'll percolate out to oscog soon.</div><div><br></div><div>Thanks!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
Thanks,<br>
Dave<br>
<br>
</blockquote></div><br>