<br><br><div class="gmail_quote">On Sat, Mar 19, 2011 at 10:36 AM, David T. Lewis <span dir="ltr"><<a href="mailto:lewis@mail.msen.com">lewis@mail.msen.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>On Sat, Mar 19, 2011 at 04:39:05PM +0100, Igor Stasenko wrote:<br>
><br>
> On 19 March 2011 17:09, <<a href="mailto:squeak-dev-noreply@lists.squeakfoundation.org">squeak-dev-noreply@lists.squeakfoundation.org</a>> wrote:<br>
> ><br>
> > Dave Lewis uploaded a new version of VMMaker to project VM Maker:<br>
> > <a href="http://www.squeaksource.com/VMMaker/VMMaker-dtl.222.mcz" target="_blank">http://www.squeaksource.com/VMMaker/VMMaker-dtl.222.mcz</a><br>
> ><br>
> > ==================== Summary ====================<br>
> ><br>
> > Name: VMMaker-dtl.222<br>
> > Author: dtl<br>
> > Time: 19 March 2011, 11:09:09 am<br>
> > UUID: 809d5eb5-6f73-4e6a-a595-428ed4536dc0<br>
> > Ancestors: VMMaker-dtl.221<br>
> ><br>
> > Fix MiscPrimitivePluginTest to properly test behavior of #primitiveFindSubstring and verify presence of a fix in TMethod>>argConversionExprFor:stackIndex: that performs type checking on string arguments.<br>
> ><br>
> ><br>
><br>
> Dave, could you check it for oscog branch too?<br>
<br>
Hi Igor,<br>
<br>
Actually I was going to reply to your earlier question about<br>
tests that you can run in an image (without VMMaker) that provide<br>
coverage for the VM. But as soon as I looked at it I realized that<br>
I has screwed this one up, so I fixed it and this the change you see<br>
posted here.<br>
<br>
There are a number of tests in the VMMaker package, mostly accumlated<br>
during bug fixing but also some stuff to support the work I did<br>
to support 64 and 32 bit images from a single code base (hence not<br>
immediately relevant for inclusion in oscog). The two tests that<br>
might be useful outside of VMMaker are JPEGReadWriter2PluginTest<br>
and MiscPrimitivePluginTest, so I am attaching fileouts for these<br>
two. Have a look and see if you thing they should go in the main<br>
Squeak/Pharo images, or stay in VMMaker(s). These two along with<br>
BitBltSimulationTest would also be suitable to include in oscog.<br>
<br>
I have stayed away from committing anything directly to the oscog<br>
branch out of concern that it may lead to confusion between the<br>
two branches if my 'dtl' initials start showing up there. I do<br>
have some changes that can be applied to oscog (mostly to get<br>
rid of cosmetic differences between the two branches that clutter<br>
up the Montecello browser). I've sent a few of these to Eliot but<br>
I don't know if that is the preferred approach going forward.<br>
Advice welcome, as I do want to put some more effort into reconciling<br>
the code bases pretty soon.<br></blockquote><div><br></div><div>I think we urgently need to merge. I haven't looked yet but has Interpreter been refactored out from under ObjectMemory? If it hasn't would you be happy for me to do that? Things that I think need to be done to Interpreter are</div>
<div><br></div><div>a) refactor it out from under ObjectMemory and under InterpreterPrimitives</div><div>b) use NewObjectMemory (it's a tad faster)</div><div>c) throw away four of the method cache fields used only by Jitter, which de facto is now obsolete, and use the StackInterpreter's folding of primitiveIndex and primitiveFunction (it's a tad faster)</div>
<div>d) also use platform-order floats (it's a tad faster)</div><div><br></div><div>What is useful about Interpreter is</div><div>a) it doesn't need a threaded or interrupt-driven heartbeat so it is simpler to port to bare metal</div>
<div>b) it uses contexts and lacks all the complexity of context-to-stack mapping and so for many VM experiments it is significantly simpler to understand and extend, and for certain context-intensive computations it may be faster</div>
<div><br></div><div>So for me its worth keeping all these VMs, but the merge task is tedious and expensive so I would like there to be only one main line.</div><div><br></div><div>are we, the VM devs (Ian, Andreas, David, Igor, Myself, others?) in agreement?</div>
<div><br></div><div>best,</div><div>Eliot</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
Dave<br>
<br>
<br></blockquote></div><br>