Hi Esteban,<br><br><div class="gmail_quote">On Thu, Mar 24, 2011 at 5:19 AM, Esteban Lorenzano <span dir="ltr"><<a href="mailto:estebanlm@gmail.com">estebanlm@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
stupid me...<br>
<br>
thanks Igor<br>
<br>
now it has 22/23 FFI tests in green :P<br></blockquote><div><br></div><div>what's the failing test?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
cheers,<br>
Esteban<br>
<br>
El 23/03/2011, a las 11:59p.m., Igor Stasenko escribió:<br>
<div><div></div><div class="h5"><br>
><br>
> On 24 March 2011 02:57, Esteban Lorenzano <<a href="mailto:estebanlm@gmail.com">estebanlm@gmail.com</a>> wrote:<br>
>><br>
>> Hi,<br>
>> I found that ThreadedIA32FFIPlugin wasn't being loaded at all... so I started debugging until I saw some details (btw... xcode4 debugger is even worst than before):<br>
>> I changed this declaration:<br>
>> #ifdef SQUEAK_BUILTIN_PLUGIN<br>
>> #undef EXPORT<br>
>> // was #undef EXPORT(returnType) but screws NorCroft cc<br>
>> #define EXPORT(returnType) static returnType<br>
>> #endif<br>
>> with:<br>
>> #ifndef SQUEAK_BUILTIN_PLUGIN<br>
>> ...<br>
>> #endif<br>
>><br>
>> also I changed:<br>
>> #ifdef SQUEAK_BUILTIN_PLUGIN<br>
>> extern<br>
>> #endif<br>
>> with:<br>
>> #ifndef SQUEAK_BUILTIN_PLUGIN<br>
>> extern<br>
>> #endif<br>
>> and then everything start working.<br>
><br>
>> I still does not know how to test the threads or callbacks for FFI, but a simple "MacOSShell new system: 'ls'." was working fine :)<br>
>> but here is my concern: the change I made looks like a heavy change... what I did is correct? should I change VMMaker code to generate plugins with my change?<br>
><br>
><br>
> An external plugins should be built without -DSQUEAK_BUILTIN_PLUGIN.<br>
> See in<br>
> CMakePluginGenerator>>generate<br>
> ...<br>
> internal ifTrue: [<br>
> self puts: 'add_definitions(-DSQUEAK_BUILTIN_PLUGIN)'].<br>
> ...<br>
><br>
> So, check the generated <root>/build/SqueakFFIPrims/CMakeLists.txt<br>
><br>
> if you build plugin as external, it should not include this flag.<br>
><br>
> And if you build it as internal, then of course it won't work :)<br>
> There are an associated code which assuming that you building dynamic library<br>
> (see platforms/Cross/plugins/SqueakFFIPrims/sqFFITestFuncs.c)<br>
><br>
><br>
>> cheers,<br>
>> Esteban<br>
>><br>
>><br>
><br>
><br>
><br>
> --<br>
> Best regards,<br>
> Igor Stasenko AKA sig.<br>
<br>
</div></div></blockquote></div><br>