I've just commited the fix, but not the comment ;)<br><br>Seriously, I don't know how we can document this kind of things. <br>Putting such comments in #compilerFlagsRelease or #compilerFlagsRelease doesn't make sense because they are aprox. 12 implementaions...I don't want to copy paste to all of them. Only in one? it doesn't make sense because people won't see it. So..how we document this kind of things? I have no idea. <br>
<br>The same with class comments. There are so many classes that copy pasting or documenting only one doesn't make sense.<br><br>The only thing I though is doing something like this:<br><br><br>compilerFlagsRelease <br>
^#('-g3' '-Os' '-fvisibility=hidden' '-funroll-loops' '-fasm-blocks' '-finline-functions' '-mfpmath=sse' '-fomit-frame-pointer' '-march=pentium-m' '-mtune=prescott' '-falign-functions=16' '-fno-gcse' '-fno-cse-follow-jumps' '-std=gnu99' '-DBUILD_FOR_OSX' '-DUSE_INLINE_MEMORY_ACCESSORS' '-DLSB_FIRST' '-DUSE_INLINE_MEMORY_ACCESSORS' '-DHAVE_SYS_TIME_H' '-DHAVE_NANOSLEEP' '-DNDEBUG=0' , self debugVMFlag: true, '-DCOGMTVM=0' '-DUSE_GLOBAL_STRUCT=0' '-DBASE_HEADER_SIZE=4')<br>
<br>>>debugVMFlagEnable: boolean<br>"THIS flag is blagh...blh..."<br>^ '-DDEBUGVM=', boolean asNumber asString<br><br>or something like that...<br><br><br>cheers<br><br>Mariano<br><br><br><div class="gmail_quote">
On Wed, Apr 13, 2011 at 6:57 PM, Igor Stasenko <span dir="ltr"><<a href="mailto:siguctua@gmail.com">siguctua@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
On 13 April 2011 18:52, Mariano Martinez Peck <<a href="mailto:marianopeck@gmail.com">marianopeck@gmail.com</a>> wrote:<br>
><br>
> Thanks Eliot for the explanation. So, some of those confs are incorrect. I will commit a fix tonight.<br>
><br>
<br>
</div>And with comments, comments! :)<br>
Thank you both!<br>
<div><div></div><div class="h5"><br>
> Mariano<br>
><br>
> On Wed, Apr 13, 2011 at 6:35 PM, Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com">eliot.miranda@gmail.com</a>> wrote:<br>
>><br>
>><br>
>><br>
>><br>
>> On Wed, Apr 13, 2011 at 9:06 AM, Mariano Martinez Peck <<a href="mailto:marianopeck@gmail.com">marianopeck@gmail.com</a>> wrote:<br>
>>><br>
>>><br>
>>> Hi Eliot. I am not sure if I understand correctly these flags, and if I do, then I think the CMake configurations are wrong.<br>
>>><br>
>>> First, what are those flags intended for? Which should be tuned on and which one off for both, release and debug ?<br>
>><br>
>> NDEBUG is a Mac OS X/FreeBSD/Linux flag that controls asserts. To get asserts working in Cog it was easiest to use this flag. So if NDEBUG=0 asserts are eliminated and if NDEBUG=1 they are included and cause a warning to be printed to stdout when enabled (via a call to warning). See platforms/Cross/vm/sqAssert.h. Hence NDEBUG=0 for production and NDEBUG=1 for debug and assert VMs.<br>
>> DEBUGVM is a flag controlling details of code generation for the entry-points that jump from the interpreter into machine code. Seer DEBUGVM and Debug in src/vm/cogit.c. I needed this early on in development when the system was flakey. Now I never use it. One might suggest eliminating it but it will probably be useful again when we add new code generators (e.g. for ARM and x86-64). So DEBUGVM=0 for production and assert VMs and either 1 or 0 for debug VMs, depending on what kind of problems you're looking to debug.<br>
>> HTH<br>
>> Eliot<br>
>>><br>
>>> In Unix/Windows conf, onlt for release, these are set:<br>
>>> -DDEBUGVM=0 -DNDEBUG<br>
>>><br>
>>> Mac Carbon release<br>
>>> -DDEBUGVM=0 -DNDEBUG=1<br>
>>><br>
>>> Mac Cocoa Cog (CocoaIOSCogConfig) debug<br>
>>> '-DNDEBUG=1' '-DDEBUGVM=0'<br>
>>><br>
>>> Mac Cocoa Cog (CocoaIOSCogConfig) release<br>
>>> '-DNDEBUG=1' '-DDEBUGVM=0'<br>
>>><br>
>>> Mac Cocoa Cog MT debug<br>
>>> -DNDEBUG=0' '-DDEBUGVM=1'<br>
>>><br>
>>> Mac Cocoa Cog MT release<br>
>>> '-DNDEBUG=0' '-DDEBUGVM=1'<br>
>>><br>
>>><br>
>>> So...this is a mess. Mac Cocoa Cog MT, have the same for both release and debug. Is this correct?<br>
>>> Mac Cocoa Cog, idem Mac Cocoa Cog MT<br>
>>><br>
>>> What is worst, Mac Cocoa Cog MT is the opposite of Mac Cocoa Cog<br>
>>><br>
>>> so...i have no idea how this should be, but sounds strange for me<br>
>>><br>
>>> Cheers<br>
>>><br>
>>> --<br>
>>> Mariano<br>
>>> <a href="http://marianopeck.wordpress.com" target="_blank">http://marianopeck.wordpress.com</a><br>
>>><br>
>>><br>
>><br>
>><br>
><br>
><br>
><br>
> --<br>
> Mariano<br>
> <a href="http://marianopeck.wordpress.com" target="_blank">http://marianopeck.wordpress.com</a><br>
><br>
><br>
><br>
<br>
<br>
<br>
</div></div><font color="#888888">--<br>
Best regards,<br>
Igor Stasenko AKA sig.<br>
</font></blockquote></div><br><br clear="all"><br>-- <br>Mariano<br><a href="http://marianopeck.wordpress.com" target="_blank">http://marianopeck.wordpress.com</a><br><br>